Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/entities checker util #145

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

jkshj21
Copy link
Collaborator

@jkshj21 jkshj21 commented Oct 16, 2023

Hello Pat,

I worked on the entities checker util class that I presented to you in the last meeting. It has various functions that validate or output entity types related data of dfcx.

If you like this class then I'm planning to add more functions like:

  • running a full entity regression test across all the pages; it checks match_type, matched value and triggeredCondition
  • merging with the pages_df and the entity_types_df to provide an insight on where the entity types are

Josh Han (joohyong)

@kmaphoenix
Copy link
Member

@MRyderOC tagging you for review. Thanks!

@kmaphoenix kmaphoenix marked this pull request as draft December 11, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants