Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc/improvement #137

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Misc/improvement #137

merged 4 commits into from
Aug 17, 2023

Conversation

MRyderOC
Copy link
Collaborator

@MRyderOC MRyderOC commented Jul 7, 2023

Some miscellaneous changes and improvements.

  • Documentaion fix
  • pylint deprecated error is fixed now. No new irrelevant errors for exceptions. To see the difference check the result of pylint github action for this branch and the main
  • misc optimization for __convert_tr_target_page in CopyUtil

@MRyderOC MRyderOC added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 7, 2023
@MRyderOC MRyderOC requested a review from kmaphoenix July 7, 2023 16:31
@MRyderOC MRyderOC self-assigned this Jul 7, 2023
@MRyderOC
Copy link
Collaborator Author

New change added for changelogs_to_dataframe in Changelogs class due to append deprecation in pandas library.

kmaphoenix
kmaphoenix approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmaphoenix kmaphoenix merged commit 9292e21 into main Aug 17, 2023
@kmaphoenix kmaphoenix deleted the misc/improvement branch August 17, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaphoenix kmaphoenix kmaphoenix approved these changes

Assignees

@MRyderOC MRyderOC

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MRyderOC @kmaphoenix