Skip to content

Commit

Permalink
Return page list instead of set; update test fixtures
Browse files Browse the repository at this point in the history
  • Loading branch information
SeanScripts committed Jul 10, 2023
1 parent 6b93fcc commit 99792c1
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/dfcx_scrapi/tools/agent_checker_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -827,4 +827,4 @@ def find_all_unreachable_intents(self) -> List[str]:
include_groups=True)
all_reachable_intents.update(set(flow_intents))
all_intents = {intent.display_name for intent in self._intent_data}
return all_intents - all_reachable_intents
return list(all_intents - all_reachable_intents)
11 changes: 11 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,16 @@
# limitations under the License.

import pytest
import json

def pytest_addoption(parser):
"""Method to add option for creds in tests."""
parser.addoption("--creds", action="store")
parser.addoption("--project_id", action="store")
parser.addoption("--gcs_bucket", action="store")
parser.addoption("--agent_id", action="store")
parser.addoption("--flow_name", action="store")
parser.addoption("--page_name", action="store")


@pytest.fixture(scope="session")
Expand All @@ -42,3 +45,11 @@ def gcs_bucket(request):
@pytest.fixture(scope="session")
def agent_id(request):
return request.config.getoption("agent_id")

@pytest.fixture(scope="session")
def flow_name(request):
return request.config.getoption("flow_name")

@pytest.fixture(scope="session")
def page_name(request):
return request.config.getoption("page_name")

0 comments on commit 99792c1

Please sign in to comment.