Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for startup script failure, montoring #432

Conversation

heyealex
Copy link
Contributor

A test for a successful startup script execution was not included for the monitoring integration test, this adds it back in similar to the spack integration test.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@nick-stroud nick-stroud assigned heyealex and unassigned nick-stroud Jul 21, 2022
@heyealex heyealex merged commit 703ce30 into GoogleCloudPlatform:develop Jul 21, 2022
@heyealex heyealex deleted the bugfix/monitoring-check-startup-failure branch July 21, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants