Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a3u-slurm-ubuntu-gcs blueprint #3435

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Add a3u-slurm-ubuntu-gcs blueprint #3435

merged 5 commits into from
Dec 30, 2024

Conversation

samskillman
Copy link
Collaborator

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

tpdownes
tpdownes reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple first comments.

examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/a3u-slurm-ubuntu-gcs.yaml Outdated Show resolved Hide resolved
examples/hypercompute_clusters/a3u-slurm-ubuntu-gcs/a3u-slurm-ubuntu-gcs.yaml Show resolved Hide resolved
@samskillman samskillman added the release-key-new-features Added to release notes under the "Key New Features" heading. label Dec 19, 2024
@samskillman samskillman force-pushed the examples/a3u-slurm-ubuntu-gcs branch from 45fd00b to 903d735 Compare December 19, 2024 23:00
@tpdownes tpdownes self-assigned this Dec 30, 2024
@tpdownes tpdownes self-requested a review December 30, 2024 19:06
tpdownes
tpdownes approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was successfully tested against v1.44.0 of the Toolkit including comparison of NCCL tests run by Ramble.

--- SUMMARY for 8GB Message Sizes --

looked accurate by eye.

@tpdownes tpdownes force-pushed the examples/a3u-slurm-ubuntu-gcs branch from 903d735 to 91b63b5 Compare December 30, 2024 19:09
@tpdownes tpdownes changed the base branch from develop to a3ultra-preview December 30, 2024 19:10
@tpdownes tpdownes merged commit c49a1f2 into GoogleCloudPlatform:a3ultra-preview Dec 30, 2024
3 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

@cboneti cboneti Awaiting requested review from cboneti

Assignees

@tpdownes tpdownes

Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samskillman @tpdownes