Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README doc review for root, cmd, and examples #327

Merged
merged 1 commit into from
May 20, 2022

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented May 19, 2022

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?


* Install GNU `findutils` with Homebrew or Conda
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these bullets no longer valid?

Copy link
Collaborator Author

@nick-stroud nick-stroud May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been discussing with @tpdownes. I have added back reference to the packages as it is the best cover all in our current state. I think long term we should find a way to update our find and install commands to be compatible with both GNU and BSD and remove this requirement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the take and the final text which is trying to find a faster path to compiling ghpc on macOS. The bottleneck being installation of XCode and Command Line Tools.

cmd/README.md Outdated Show resolved Hide resolved
@heyealex heyealex assigned nick-stroud and unassigned heyealex May 19, 2022
@heyealex heyealex assigned nick-stroud and unassigned heyealex May 20, 2022
@nick-stroud nick-stroud merged commit 46167a6 into GoogleCloudPlatform:develop May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants