Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update a3-megagpu-8 example to use local ssd solution #2871

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Update a3-megagpu-8 example to use local ssd solution #2871

merged 1 commit into from
Aug 6, 2024

Conversation

alyssa-sm
Copy link
Contributor

Updates the a3-megagpu-8 example to use the local ssd solution outlined in #2720.

@alyssa-sm alyssa-sm added the release-chore To not include into release notes label Aug 5, 2024
@alyssa-sm alyssa-sm self-assigned this Aug 5, 2024
@alyssa-sm alyssa-sm force-pushed the update-megagpu-example branch from 90799f8 to f104914 Compare August 5, 2024 18:50
@alyssa-sm alyssa-sm added release-improvements Added to release notes under the "Improvements" heading. and removed release-chore To not include into release notes labels Aug 5, 2024
@alyssa-sm alyssa-sm assigned tpdownes and unassigned alyssa-sm Aug 5, 2024
@tpdownes tpdownes mentioned this pull request Aug 6, 2024
Merged
tpdownes
tpdownes requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment here is important. Please also trigger the integration test for a3-megagpu-8g after you make the change.

examples/machine-learning/a3-megagpu-8g/slurm-a3mega-cluster.yaml Outdated Show resolved Hide resolved
@tpdownes tpdownes assigned alyssa-sm and unassigned tpdownes Aug 6, 2024
@alyssa-sm alyssa-sm force-pushed the update-megagpu-example branch from f104914 to cb8c7fb Compare August 6, 2024 21:34
@alyssa-sm alyssa-sm requested a review from tpdownes August 6, 2024 21:34
@alyssa-sm alyssa-sm assigned tpdownes and unassigned alyssa-sm Aug 6, 2024
@tpdownes tpdownes assigned alyssa-sm and unassigned tpdownes Aug 6, 2024
@alyssa-sm alyssa-sm merged commit 2b62970 into GoogleCloudPlatform:develop Aug 6, 2024
9 of 51 checks passed
@alyssa-sm alyssa-sm deleted the update-megagpu-example branch August 6, 2024 22:25
@tpdownes tpdownes mentioned this pull request Aug 15, 2024
Merged
@nick-stroud nick-stroud mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@alyssa-sm alyssa-sm

Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssa-sm @tpdownes