Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce default maximum number of HTCondor execute points #2127

Merged

Conversation

tpdownes
Copy link
Member

Especialy for initial deployments, a maximum of 100 could result in significant spend beyond what was anticipated. Reducing to 5 addresses this while still allowing the user to deliberately scale up.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Especialy for initial deployments, a maximum of 100 could result in
significant spend beyond what was anticipated. Reducing to 5 addresses
this while still allowing the user to deliberately scale up.
@tpdownes tpdownes requested a review from cdunbar13 January 11, 2024 16:31
@tpdownes tpdownes added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Jan 11, 2024
@cdunbar13 cdunbar13 assigned tpdownes and unassigned cdunbar13 Jan 11, 2024
@tpdownes tpdownes merged commit a75134e into GoogleCloudPlatform:develop Jan 11, 2024
6 of 33 checks passed
@tpdownes tpdownes deleted the reduce_htcondor_default_size branch January 11, 2024 19:29
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants