Fix the way of GitHub module handling #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to share my progress with you @tpdownes . I would appreciate if you could review my work and check if I'm going in the right direction.
1. Support Terraform modules at the root of GitHub repos
HPC Toolkit currently doesn't support modules at the root of GitHub repos when they are specified like below.
This will be fixed by this commit which is based on hashicorp/go-getter - Using git always gives error 128 #114.
2. Download remote modules only for the purpose of running terraform-config-inspect, and not save them into blueprints output directory
HPC Toolkit currently downloads modules from GitHub repos and saves them with URL parameters under
modules
directory in a blueprint directory when they are specified like below.The current solution creates a git repository in a subdirectory of the blueprint. We anticipate that many users will want to manage blueprints with git. So, we are effectively requiring them to use git submodules ("git inside git"). Which is difficult. In addition, downloading GitHub modules is not required for Terraform and directory names with '?' and '=' are not safe in general, so this commit will update the tool to take the following actions:
Current output
Expected output
Submission Checklist
pre-commit install
make tests
change?
guides?