Skip to content

Commit

Permalink
Merge pull request #3200 from ankitkinra/gke-update-default-taints
Browse files Browse the repository at this point in the history
Gke update default taints for user node pools
ankitkinra authored Nov 1, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
2 parents 2599453 + ba7a967 commit b163a4c
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion modules/compute/gke-node-pool/README.md
Original file line number Diff line number Diff line change
@@ -307,7 +307,7 @@ limitations under the License.
| <a name="input_service_account_scopes"></a> [service\_account\_scopes](#input\_service\_account\_scopes) | Scopes to to use with the node pool. | `set(string)` | <pre>[<br/> "https://www.googleapis.com/auth/cloud-platform"<br/>]</pre> | no |
| <a name="input_spot"></a> [spot](#input\_spot) | Provision VMs using discounted Spot pricing, allowing for preemption | `bool` | `false` | no |
| <a name="input_static_node_count"></a> [static\_node\_count](#input\_static\_node\_count) | The static number of nodes in the node pool. If set, autoscaling will be disabled. | `number` | `null` | no |
| <a name="input_taints"></a> [taints](#input\_taints) | Taints to be applied to the system node pool. | <pre>list(object({<br/> key = string<br/> value = any<br/> effect = string<br/> }))</pre> | <pre>[<br/> {<br/> "effect": "NO_SCHEDULE",<br/> "key": "user-workload",<br/> "value": true<br/> }<br/>]</pre> | no |
| <a name="input_taints"></a> [taints](#input\_taints) | Taints to be applied to the system node pool. | <pre>list(object({<br/> key = string<br/> value = any<br/> effect = string<br/> }))</pre> | `[]` | no |
| <a name="input_threads_per_core"></a> [threads\_per\_core](#input\_threads\_per\_core) | Sets the number of threads per physical core. By setting threads\_per\_core<br/>to 2, Simultaneous Multithreading (SMT) is enabled extending the total number<br/>of virtual cores. For example, a machine of type c2-standard-60 will have 60<br/>virtual cores with threads\_per\_core equal to 2. With threads\_per\_core equal<br/>to 1 (SMT turned off), only the 30 physical cores will be available on the VM.<br/><br/>The default value of \"0\" will turn off SMT for supported machine types, and<br/>will fall back to GCE defaults for unsupported machine types (t2d, shared-core<br/>instances, or instances with less than 2 vCPU).<br/><br/>Disabling SMT can be more performant in many HPC workloads, therefore it is<br/>disabled by default where compatible.<br/><br/>null = SMT configuration will use the GCE defaults for the machine type<br/>0 = SMT will be disabled where compatible (default)<br/>1 = SMT will always be disabled (will fail on incompatible machine types)<br/>2 = SMT will always be enabled (will fail on incompatible machine types) | `number` | `0` | no |
| <a name="input_timeout_create"></a> [timeout\_create](#input\_timeout\_create) | Timeout for creating a node pool | `string` | `null` | no |
| <a name="input_timeout_update"></a> [timeout\_update](#input\_timeout\_update) | Timeout for updating a node pool | `string` | `null` | no |
6 changes: 1 addition & 5 deletions modules/compute/gke-node-pool/variables.tf
Original file line number Diff line number Diff line change
@@ -230,11 +230,7 @@ variable "taints" {
value = any
effect = string
}))
default = [{
key = "user-workload"
value = true
effect = "NO_SCHEDULE"
}]
default = []
}

variable "labels" {

0 comments on commit b163a4c

Please sign in to comment.