Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dialer default behavior to "PUBLIC, PRIVATE" instead of just "PUBLIC". #294

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Update dialer default behavior to "PUBLIC, PRIVATE" instead of just "PUBLIC". #294

merged 1 commit into from
Jul 11, 2019

Conversation

kurtisvg
Copy link
Contributor

Fixes #293.

@kurtisvg kurtisvg requested review from hfwang and broady July 11, 2019 16:00
@kurtisvg kurtisvg added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jul 11, 2019
@kurtisvg kurtisvg merged commit f0b00cc into master Jul 11, 2019
@kurtisvg kurtisvg deleted the default-ip branch July 11, 2019 18:23
@kurtisvg kurtisvg mentioned this pull request Aug 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broady broady broady approved these changes

@hfwang hfwang Awaiting requested review from hfwang

Assignees
No one assigned
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default dialer address to "PUBLIC,PRIVATE"
3 participants
@kurtisvg @broady @googlebot