Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy rejects requests for first generation instances. #269

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

hfwang
Copy link
Contributor

@hfwang hfwang commented Apr 4, 2019

First generation instances are not supported by the proxy, so this causes connections to them to fail slightly faster (otherwise we need to wait for the connection to timeout!)

First generation instances are not supported by the proxy, so this causes them to fail slightly faster.
@hfwang hfwang requested a review from kurtisvg April 4, 2019 00:57
Copy link
Contributor

@Carrotman42 Carrotman42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally you should return errors or log them, not both.

@hfwang
Copy link
Contributor Author

hfwang commented Apr 4, 2019

The log and error have slightly different content... @Carrotman42 are you OK with that? Or would you rather I remove the logs altogether?

Copy link
Contributor

@Carrotman42 Carrotman42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't matter too much, people shouldn't try to do v1 connections anyway.

Sorry for the delay.

@hfwang hfwang merged commit c70a36b into GoogleCloudPlatform:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants