Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump proxy version in examples #2254

Merged
merged 2 commits into from
Jun 17, 2024
Merged

chore: bump proxy version in examples #2254

merged 2 commits into from
Jun 17, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

@jackwotherspoon jackwotherspoon commented Jun 14, 2024 •
edited
Loading

Bump examples to use latest proxy version.

@jackwotherspoon jackwotherspoon requested a review from a team as a code owner June 14, 2024 13:52
@jackwotherspoon jackwotherspoon self-assigned this Jun 14, 2024
enocom
enocom reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put renovate tags around these like we did in the README?

@jackwotherspoon jackwotherspoon requested a review from enocom June 17, 2024 15:11
@jackwotherspoon
Copy link
Collaborator Author

Can we put renovate tags around these like we did in the README?

I have updated the README's to get auto-bumped with release-please, the yaml files I have left out as most of them contain the 0.0.0.0 which has been causing issues for us as it gets mistaken as a Proxy version.

enocom
enocom approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

enocom
enocom approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jackwotherspoon jackwotherspoon merged commit a74fbf7 into main Jun 17, 2024
12 checks passed
@jackwotherspoon jackwotherspoon deleted the bump-examples branch June 17, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackwotherspoon @enocom