Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure proxy shutsdown cleanly on fuse error #2205

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

enocom
Copy link
Member

@enocom enocom commented Apr 25, 2024

If the fuse server fails to mount, the call to Close should not panic. This commit ensures that no panic's happen if fuse isn't properly configured.

Fixes #2013

@enocom enocom requested a review from a team as a code owner April 25, 2024 14:47
If the fuse server fails to mount, the call to Close should not panic.
This commit ensures that no panic's happen if fuse isn't properly
configured.

Fixes #2013
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@enocom enocom merged commit 54e65d1 into main Apr 26, 2024
12 checks passed
@enocom enocom deleted the graceful-close branch April 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when fuse fails to start
2 participants