Terminate gracefully after receiving a SIGTERM signal. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a SIGTERM handler to the client with a configurable termination grace period (default 20s). During this period the client will refuse new connections. At the end of the period the process will exit. This allows in-flight database operations to complete when running as a sidecar container in Kubernetes and performing rolling updates.
|
This doesn't fully solve the issue AFAICT since other containers might try to establish connections even after being asked to terminate. An example chain of events: Web request hits application server -> pod is asked to terminate -> proxy receives sigterm -> application server tries to establish db connection resulting in error since the connection can't be established. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #128
Added a SIGTERM handler to the client with a configurable termination grace period (default 20s). During this period the client will refuse new connections. At the end of the period the process will exit. This allows in-flight database operations to complete when running as a sidecar container in Kubernetes and performing rolling updates.