Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use proper error instance to write error log #2014

Merged

Conversation

FGtatsuro
Copy link
Contributor

Now, we use cloud-sql-proxy, and encounter an error as follows.

[{my-instance-name}] connection aborted - error writing to client: <nil>

we checked code, and noticed that nil error instance was used for logging.

@FGtatsuro FGtatsuro requested a review from a team as a code owner November 2, 2023 04:59
@jackwotherspoon jackwotherspoon added the tests: run Label to trigger Github Action tests. label Nov 2, 2023
@github-actions github-actions bot removed the tests: run Label to trigger Github Action tests. label Nov 2, 2023
@jackwotherspoon jackwotherspoon changed the title fix: Use a proper error instance to write an error log. fix: use proper error instance to write error log Nov 2, 2023
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @FGtatsuro! Good find 😄

@jackwotherspoon jackwotherspoon merged commit cc76a54 into GoogleCloudPlatform:main Nov 2, 2023
9 checks passed
@FGtatsuro FGtatsuro deleted the fix/error_for_log branch November 2, 2023 15:52
@FGtatsuro
Copy link
Contributor Author

@ jackwotherspoon
Thank you for your quick response! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants