-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Windows Service support #1696
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
Wow! Thanks for this PR! I'll take a look today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
Tests would be nice ;-)
A few questions and minor suggestions.
And to answer you questions:
For now, installing from the Releases page seems fine to me.
This is also easy to change in the future, so I'm inclined to start with a hard-coded path and update if there's interest.
Might be another nice enhancement, but we can ship this once we work through review. So I'm ok with not doing this yet. |
@fkollmann Friendly ping. If you'd like some help getting this finished, let me know. You've already done the majority of the work. 😄 |
Thank you. Sry, I was busy playing Diablo IV beta this weekend 😅. I will get back to you on Thursday. |
😆 No worries. Again this is a helpful contribution, so I'm happy to lend a hand wherever needed. |
I went through the comments and see no major issues, besides a minor misunderstanding on Windows services. I will answer the comments tomorrow and make some changes. |
Short update: I had to change plans for the weekend. I have time for providing feedback today. |
I did some code changes and marked the suggestions as resolved. (Please let me know if I should have kept the suggestions unresolved, or not). Looking forward to your feedback. |
Sorry for the slow response. I'll get to this soon. |
Don't worry. No pressure from my side. We are currently using it on production, so it at least works for us 😅 |
Currently running this through some manual tests. We can probably get this into the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just a few comments.
Do we need to add a note about UAC as a possible thing to investigate if it doesn't work?
@fkollmann There are a few small changes to make here that I'm going to do. And then I'll merge this. |
Looks like I can't push to your fork. You can change that, though. See here. Alternatively, aside from the two typos @jackwotherspoon pointed out, we need to keep a |
Hi, sry, I was on vacation the last week, incl today. I will look into this tomorrow. Have a nice evening :) . Best Regards, Felix |
(instead of using build tag filename convention)
That is currently not support with forks below other organizations (instead of individual users). However, I granted you maintainer permissions on the repo. |
Okay, I addressed everything, from my POV. Please feel free to comment (and change). @enocom |
Looks great! Thanks again for this contribution! |
This PR adds support for running the Cloud SQL Proxy as Windows service.
More details on how to install, can be found in the
windows-service-guide.md
file.Tested on Windows Server 2019.
If the executable is run from the command line directly, it will run normally like before.
Please see it as a first draft based on my multi-year experience with running Go apps as Windows services.
Open questions are:
Implements #277