Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for quitquitquit endpoint #1624

Merged
merged 6 commits into from
Jan 31, 2023
Merged

feat: add support for quitquitquit endpoint #1624

merged 6 commits into from
Jan 31, 2023

Conversation

enocom
Copy link
Member

@enocom enocom commented Jan 26, 2023

Fixes #828.

@enocom enocom requested a review from a team as a code owner January 26, 2023 18:40
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I suggested alternate wording for the --quitquitquit flag's help.

cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@enocom enocom requested a review from hessjcg January 27, 2023 22:15
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enocom enocom merged commit 43f9857 into main Jan 31, 2023
@enocom enocom deleted the quitquitquit branch January 31, 2023 21:35
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Feb 2, 2023
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Feb 3, 2023
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to shutdown the process from another container
3 participants