Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TCP keep-alive to client side #161

Merged
merged 4 commits into from
Aug 22, 2018

Conversation

sigxcpu76
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@sigxcpu76
Copy link
Contributor Author

This patches the client-side TCP connection with keep-alive (60 seconds interval) as a fix for #147

@kurtisvg kurtisvg added Status: Proposal type: cleanup An internal cleanup or hygiene concern. labels Jul 16, 2018
@hfwang
Copy link
Contributor

hfwang commented Aug 14, 2018

Sorry for the long delay. The change looks good!

I'm going to pull this into the Google internal repository, and test it internally for this week, assuming all goes well, I'll merge this!

@robsonpeixoto
Copy link

News @hfwang ?

Customers have complained about extraneous logs, hence the log removal.
SetLinger(2) doesn't seem strictly necessary, and we'd prefer not to change more than needed.
@hfwang hfwang requested a review from easwars August 22, 2018 21:05
@hfwang
Copy link
Contributor

hfwang commented Aug 22, 2018

Some comments were made when this was reviewed internally, I've removed the extra log line and the call to SetLinger. Over to easwars for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants