-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TCP keep-alive to client side #161
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLAs look good, thanks! |
This patches the client-side TCP connection with keep-alive (60 seconds interval) as a fix for #147 |
Sorry for the long delay. The change looks good! I'm going to pull this into the Google internal repository, and test it internally for this week, assuming all goes well, I'll merge this! |
News @hfwang ? |
Customers have complained about extraneous logs, hence the log removal. SetLinger(2) doesn't seem strictly necessary, and we'd prefer not to change more than needed.
Some comments were made when this was reviewed internally, I've removed the extra log line and the call to SetLinger. Over to easwars for review! |
No description provided.