Stdout and Stderr Loggers #150

krak3n · 2018-03-02T10:04:01Z

Related issues: #106 #138 #149

We noticed that debug messages from our Cloud SQL proxy would be considered as errors in stack driver since all log messages are sent to stderr as is defined by the default logger in the go log package: https://golang.org/src/log/log.go?#L73

This Pull requests sets up two new loggers, one for verbose / info messages which log to stdout and one for error messages which log to stderr.

I believe this should fix the problems as described in #138

googlebot · 2018-03-02T10:04:04Z

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

krak3n · 2018-03-02T10:06:32Z

I've signed it!

googlebot · 2018-03-02T10:06:47Z

CLAs look good, thanks!

Carrotman42 · 2018-03-02T15:26:45Z

People likely rely on the current implementation. In order to not break people, please flag off this feature so that the default functionality is unchanged. If this is really what most people want, we can consider changing the default in a later release.

krak3n · 2018-03-02T15:53:10Z

@Carrotman42 I have add a flag with a default false value.

krak3n · 2018-03-02T15:53:39Z

logging/logging.go

+
+// LogDebugToStdout updates Verbose and Info logging to use stdout instead of stderr.
+func LogDebugToStdout() {
+	logger := log.New(os.Stdout, "", log.LstdFlags)


Not sure if this is best way to do this 🤔

I'm pretty torn on this one too. I don't like that cloud_sql_proxy.go now has two different styles of overriding the logging style.

IMO it would probably be better if there was a "LogVerboseToNowhere" method in this package, and have line 394 of cloud_sql_proxy.go call that instead. Would you mind making that one last change?

d-winter · 2018-04-05T11:28:58Z

Any idea when this will get merged?

Carrotman42 · 2018-04-05T14:11:54Z

Sorry, I don't have write/merge access to this repo any more. (Ive moved teams inside Google.)

…

On Thu, Apr 5, 2018, 4:29 AM Daniel Winter ***@***.***> wrote: Any idea when this will get merged? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiy7063IUY_tdW0sosl5ZDL-ZYnwrQSks5tlf_6gaJpZM4SZqhO> .

chrissound · 2018-04-09T12:44:20Z

+1 anxiously waiting for this..

hfwang · 2018-04-13T04:23:59Z

cmd/cloud_sql_proxy/cloud_sql_proxy.go

@@ -119,6 +120,9 @@ General:
    WARNING: this option disables ALL logging output (including connection
    errors), which will likely make debugging difficult. The -quiet flag takes
    precedence over the -verbose flag.
+  -log_debug_stdout
+    When explicitly set to true, verbose and info log messages will be directed
+	stdout as a pose to the default stderr.


'to stdout as opposed to the default stderr'

Just pushed a fix

kYann · 2018-04-17T20:31:08Z

👍 Need this too !

hfwang · 2018-04-19T07:29:10Z

cmd/cloud_sql_proxy/cloud_sql_proxy.go

+	version        = flag.Bool("version", false, "Print the version of the proxy and exit")
+	verbose        = flag.Bool("verbose", true, "If false, verbose output such as information about when connections are created/closed without error are suppressed")
+	quiet          = flag.Bool("quiet", false, "Disable log messages")
+	logDebugStdout = flag.Bool("log_debug_stdout", false, "If true, log messages that are not errors will outout to stdout instead of stderr")


Sorry to not catch this earlier, but it says "outout" instead of output.

I need to turn spell check on. Pushed a fix 👍

Thanks, and sorry for the nitpicking ;)

ricardocabral · 2018-04-19T21:35:37Z

Do you know any workarounds?

adding "2>&1" as a last argument to the deployment command didn't help.

hfwang · 2018-04-21T20:28:58Z

@krak3n I think we're good to go. Would you mind doing one last "little change" so that changing logging settings is a bit more consistent?

Otherwise it looks good to me, so if you don't want to make that change, I can do it myself.

krak3n · 2018-04-21T21:31:19Z

Sure, I'm not at my computer this evening but will update tomorrow. Thanks guys :)

On Sat, 21 Apr 2018, 21:29 Hsiu-Fan Wang, ***@***.***> wrote: @krak3n <https://github.com/krak3n> I think we're good to go. Would you mind doing one last "little change" so that changing logging settings is a bit more consistent? Otherwise it looks good to me, so if you don't want to make that change, I can do it myself. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG2wm7LN8D8yGCGPE0l5DwX7Et_OIbjks5tq5aLgaJpZM4SZqhO> .

-- Chris Reeves | Senior Developer

…

______________________________________________ M: +44 (0) 20 70000000 | T: +44 (0) 20 7190 9759 Second Floor, 16-24 Underwood Street, London N1 7JQ Website <https://thisissoon.com/> | Twitter <https://www.twitter.com/soonlondon> | Instagram <https://www.instagram.com/soonpics/>

______________________________________________ New from SOON_ New site for ParalympicsGB Check it out here <https://thisissoon.com/project/paralympics-site/>

Carrotman42 · 2018-04-25T16:52:52Z

logging/logging.go


 // Verbosef is called to write verbose logs, such as when a new connection is
-// established correctly.


Please fix these comments you deleted?

@Carrotman42 sorry this took so long, I've pushed a fix 👍

gytisgreitai · 2018-06-14T10:22:10Z

@krak3n are you planning to proceed with this?

krak3n · 2018-06-18T09:00:59Z

@gytisgreitai yes I do, I'll try and get the fixes requested in ASAP, life / work is currently very busy 😬

hfwang · 2018-09-21T01:29:01Z

LGTM. Sorry for the delay, I didn't realize there had been updates pushed.

Setup loggers specifically for stdout and stderr

16d4461

protect logging to stdout with a CLI flag defaulted to false

f08e5a4

krak3n commented Mar 2, 2018

View reviewed changes

This was referenced Apr 13, 2018

Cloud SQL Proxy logs show up as severity: ERROR in Stackdriver logging when using Kubernetes #138

Closed

Logging to stdout instead of stderr ? #106

Closed

hfwang reviewed Apr 13, 2018

View reviewed changes

fix missing "to" in -log_debug_stdout flag description text

2db6d66

hfwang reviewed Apr 19, 2018

View reviewed changes

fix spelling error in logDebugStdout flag description

1e322f3

Carrotman42 reviewed Apr 25, 2018

View reviewed changes

Carrotman42 mentioned this pull request Apr 25, 2018

Cleanup Logging Levels #149

Closed

kurtisvg added Status: Changes Requested type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 16, 2018

krak3n added 2 commits August 3, 2018 10:15

fix accidental comment deletion

4b286e5

add new LogVerboseToNowhere method to discord verbose messages

ec52e49

kurtisvg added the Status: Review Needed label Aug 3, 2018

kurtisvg removed the Status: Changes Requested label Aug 3, 2018

hfwang self-assigned this Sep 20, 2018

hfwang merged commit 634f088 into GoogleCloudPlatform:master Sep 21, 2018

kurtisvg mentioned this pull request Nov 15, 2018

Logs are being treated as errors in stackdriver #223

Closed

bshouse mentioned this pull request Jan 11, 2019

New connection for "myproject:region:db". Client closed local connection on 127.0.0.1:5432 #190

Closed

shubha-rajan mentioned this pull request Feb 25, 2020

Connection statuses logged as errors #355

Closed

kurtisvg mentioned this pull request Mar 4, 2020

net/http: timeout awaiting response headers #357

Closed

shubha-rajan mentioned this pull request Aug 15, 2020

Documentation missing for log_debug_std flag #428

Closed

shubha-rajan mentioned this pull request Oct 22, 2020

Info messages saved into stderr #510

Closed

shubha-rajan mentioned this pull request Dec 1, 2020

How to set SQL Proxy log severity (Log Viewer) #551

Closed

kemics mentioned this pull request Dec 25, 2022

Change standard output destination depending on log level grafana/loki#6459

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stdout and Stderr Loggers #150

Stdout and Stderr Loggers #150

krak3n commented Mar 2, 2018 •

edited

Loading

googlebot commented Mar 2, 2018

krak3n commented Mar 2, 2018

googlebot commented Mar 2, 2018

Carrotman42 commented Mar 2, 2018

krak3n commented Mar 2, 2018

krak3n Mar 2, 2018

hfwang Apr 21, 2018

d-winter commented Apr 5, 2018

Carrotman42 commented Apr 5, 2018 via email

chrissound commented Apr 9, 2018

hfwang Apr 13, 2018

krak3n Apr 18, 2018

kYann commented Apr 17, 2018

hfwang Apr 19, 2018

krak3n Apr 19, 2018

hfwang Apr 21, 2018

ricardocabral commented Apr 19, 2018

hfwang commented Apr 21, 2018

krak3n commented Apr 21, 2018 via email

Carrotman42 Apr 25, 2018

krak3n Aug 3, 2018

gytisgreitai commented Jun 14, 2018

krak3n commented Jun 18, 2018

hfwang commented Sep 21, 2018


		// Verbosef is called to write verbose logs, such as when a new connection is
		// established correctly.

Stdout and Stderr Loggers #150

Stdout and Stderr Loggers #150

Conversation

krak3n commented Mar 2, 2018 • edited Loading

googlebot commented Mar 2, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

krak3n commented Mar 2, 2018

googlebot commented Mar 2, 2018

Carrotman42 commented Mar 2, 2018

krak3n commented Mar 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

d-winter commented Apr 5, 2018

Carrotman42 commented Apr 5, 2018 via email

chrissound commented Apr 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kYann commented Apr 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ricardocabral commented Apr 19, 2018

hfwang commented Apr 21, 2018

krak3n commented Apr 21, 2018 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gytisgreitai commented Jun 14, 2018

krak3n commented Jun 18, 2018

hfwang commented Sep 21, 2018

krak3n commented Mar 2, 2018 •

edited

Loading