-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuring proxy with environment variables #225
Comments
We're working on some major structural improvements to the proxy. Once those are complete, we'll come back to address this issue. |
This work will unblock #1045. |
What if we did a kind of naming scheme for the environment variables:
|
I think we should make the list of instance connection names zero indexed and also define an INSTANCE_CONNECTION_NAME variable for the first instance, for the cases when someone is connecting to only a single instance:
|
Also, to configure individual instances, we'll continue to use query params:
|
With instances being a command line argument I cannot use k8s secrets to set the instance and then recycle the same deployment.yaml file between environments, but rather resort to a generator for the k8s config.
An example can be found at:
https://github.com/itkj/docker-cloud-sql-proxy/blob/master/Dockerfile#L10
from itkj/docker-cloud-sql-proxy on docker hub.
The text was updated successfully, but these errors were encountered: