Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readiness probe shouldn't depend on downstream services #2083

Closed
enocom opened this issue Jan 13, 2024 · 0 comments · Fixed by #2207 or #2195
Closed

Readiness probe shouldn't depend on downstream services #2083

enocom opened this issue Jan 13, 2024 · 0 comments · Fixed by #2207 or #2195
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@enocom
Copy link
Member

enocom commented Jan 13, 2024 •
edited
Loading

Cf. https://github.com/zegl/kube-score/blob/master/README_PROBES.md#readinessprobe

Also, the readiness probe should respond differently after the process received a SIGTERM.
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 13, 2024
@enocom enocom assigned enocom and unassigned jackwotherspoon Jan 22, 2024
@enocom enocom mentioned this issue Jan 23, 2024
Closed
enocom added a commit that referenced this issue May 1, 2024
@enocom
fix: don't depend on downstream in readiness check
2d354fe 
The readiness probe should not depend on downstream connections. Doing
so can cause unwanted downtime. See [1]. This commit removes all dialing
of downstream database servers as a result.

In addition, after the Proxy receives a SIGTERM or SIGINT, the readiness
check will now report an unhealthy status to ensure it is removed from
circulation before shutdown completes.

[1]: https://github.com/zegl/kube-score/blob/master/README_PROBES.md#readinessprobe

Fixes #2083
enocom added a commit that referenced this issue May 1, 2024
@enocom
fix: don't depend on downstream in readiness check
ca82605 
The readiness probe should not depend on downstream connections. Doing
so can cause unwanted downtime. See [1]. This commit removes all dialing
of downstream database servers as a result.

In addition, after the Proxy receives a SIGTERM or SIGINT, the readiness
check will now report an unhealthy status to ensure it is removed from
circulation before shutdown completes.

[1]: https://github.com/zegl/kube-score/blob/master/README_PROBES.md#readinessprobe

Fixes #2083
enocom added a commit that referenced this issue May 1, 2024
@enocom
fix: don't depend on downstream in readiness check
2c51ae1 
The readiness probe should not depend on downstream connections. Doing
so can cause unwanted downtime. See [1]. This commit removes all dialing
of downstream database servers as a result.

In addition, after the Proxy receives a SIGTERM or SIGINT, the readiness
check will now report an unhealthy status to ensure it is removed from
circulation before shutdown completes.

[1]: https://github.com/zegl/kube-score/blob/master/README_PROBES.md#readinessprobe

Fixes #2083
@enocom enocom mentioned this issue May 1, 2024
Merged
enocom added a commit that referenced this issue May 1, 2024
@enocom
fix: don't depend on downstream in readiness check
6e70fb5 
The readiness probe should not depend on downstream connections. Doing
so can cause unwanted downtime. See [1]. This commit removes all dialing
of downstream database servers as a result.

In addition, after the Proxy receives a SIGTERM or SIGINT, the readiness
check will now report an unhealthy status to ensure it is removed from
circulation before shutdown completes.

[1]: https://github.com/zegl/kube-score/blob/master/README_PROBES.md#readinessprobe

Fixes #2083
enocom added a commit that referenced this issue May 8, 2024
@enocom
fix: don't depend on downstream in readiness check (#2207)
49fa927 
The readiness probe should not depend on downstream connections. Doing
so can cause unwanted downtime. See [1]. This commit removes all dialing
of downstream database servers as a result.

In addition, after the Proxy receives a SIGTERM or SIGINT, the readiness
check will now report an unhealthy status to ensure it is removed from
circulation before shutdown completes.

[1]: https://github.com/zegl/kube-score/blob/master/README_PROBES.md#readinessprobe

Fixes #2083
@release-please release-please bot mentioned this issue May 6, 2024
Merged
@BrewTestBot BrewTestBot mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@enocom @jackwotherspoon