Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for debug logging #1938

Closed
enocom opened this issue Sep 1, 2023 · 1 comment · Fixed by #2107
Closed

Add support for debug logging #1938

enocom opened this issue Sep 1, 2023 · 1 comment · Fixed by #2107
Assignees
@enocom
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@enocom
Copy link
Member

enocom commented Sep 1, 2023

Feature Description

Now that slog is GA, we should use it here with a --debug flag.

Callers should be able to turn on debug logging to see:

  1. When a refresh starts
  2. When a refresh finishes
  3. When a refresh errors
  4. When the current TLS certificate expires
  5. and any other useful information

In addition, this should propagate to the Go Connector in the form of an option: cloudsqlconn.WithDebugLogger.

Sample code

// sample code here

Alternatives Considered

No response

Additional Details

No response
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 1, 2023
@enocom enocom added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 19, 2024
@enocom enocom assigned enocom and unassigned jackwotherspoon Jan 22, 2024
@enocom
Copy link
Member Author

enocom commented Feb 13, 2024

The Go Connector now supports debug logging: GoogleCloudPlatform/cloud-sql-go-connector#726

enocom added a commit that referenced this issue Feb 14, 2024
@enocom
feat: add support for debug logging
4a10d3f 
Fixes #1938.
@enocom enocom mentioned this issue Feb 14, 2024
Merged
enocom added a commit that referenced this issue Feb 14, 2024
@enocom
feat: add support for debug logging
f6b6b66 
Fixes #1938.
enocom added a commit that referenced this issue Feb 14, 2024
@enocom
feat: add support for debug logging
d3da9e2 
Fixes #1938.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for debug logging GoogleCloudPlatform/cloud-sql-proxy
2 participants
@enocom @jackwotherspoon