docs: Add example job that shuts down proxy containers on completion. #436
Conversation
hessjcg
force-pushed
the
gh-361-job-docs
branch
3 times, most recently
from
68d893d to
6276412
Compare
docs/examples/job-mysql.yaml
Outdated
| command: | ||
| - sh | ||
| - -c | ||
| - "psql --host=$DB_HOST --port=$DB_PORT --username=$DB_USER '--command=select 1' --echo-queries --dbname=$DB_NAME\nfor url in $CSQL_QUIT_URLS ; do \n wget --post-data '' $url \ndone\n" |
There was a problem hiding this comment.
Does the busybox image have curl? I think that might be more clear than wget.
There was a problem hiding this comment.
The busybox image has wget but not curl.
There was a problem hiding this comment.
Ah ok. Well either way, we can change this to a get request once the next version of the Proxy is released yeah?
There was a problem hiding this comment.
Can we clean up the whitespace here? Is there any way to make this more readable? If we end up putting this in the docs one day, the horizontal scroll will be brutal.
There was a problem hiding this comment.
Yes. This is now fixed.
hessjcg
force-pushed
the
gh-361-job-docs
branch
2 times, most recently
from
0985fe0 to
04427d4
Compare
docs/examples/job-mysql.yaml
Outdated
| # This demonstrates how to configure a batch job so that it shuts down | ||
| # the proxy containers when it has finished processing. | ||
| # | ||
| # The operator will set an environment variable called CSQL_QUIT_URLS |
There was a problem hiding this comment.
I missed this in review, but shouldn't this be CSQL_PROXY_QUIT_URLS?
There was a problem hiding this comment.
Yes, glad you caught this. I opened #454 with the fix. I'll update this PR too.
docs/examples/job-mysql.yaml
Outdated
| # so the value of CSQL_QUIT_URLS will be something like | ||
| # "http://localhost:9091/quitquitquit" | ||
| # | ||
| # The main job container should send a POST request each URL when the job |
There was a problem hiding this comment.
POST or GET? GET is so much more convenient.
hessjcg
force-pushed
the
gh-361-job-docs
branch
from
04427d4 to
5707e41
Compare
Demonstrate how to configure a job so that job containers exit successfully when the job completes.
Related to #361