Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudsql-proxy user agent env variable for tracking #67

Closed
hessjcg opened this issue Oct 10, 2022 · 0 comments · Fixed by GoogleCloudPlatform/cloud-sql-proxy#1542 or #122
Closed

Add cloudsql-proxy user agent env variable for tracking #67

hessjcg opened this issue Oct 10, 2022 · 0 comments · Fixed by GoogleCloudPlatform/cloud-sql-proxy#1542 or #122
Assignees
@enocom @shubha-rajan
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v0.1 Private Preview

Comments

@hessjcg
Copy link
Collaborator

hessjcg commented Oct 10, 2022

Add an environment variable CLOUD_SQL_PROXY_OPERATOR_VERSION to the proxy container with the operator version and build information

Enhance the proxy to read CLOUD_SQL_PROXY_OPERATOR_VERSION and add this value to its request User-Agent header when making requests to the google cloud API
@hessjcg hessjcg added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p0 labels Oct 10, 2022
@hessjcg hessjcg modified the milestones: v1.0 GA, v0.5 public preview Oct 10, 2022
@hessjcg hessjcg removed their assignment Oct 10, 2022
@hessjcg hessjcg added priority: p0 Highest priority. Critical issue. P0 implies highest priority. and removed priority: p0 labels Oct 28, 2022
@shubha-rajan shubha-rajan mentioned this issue Nov 11, 2022
Merged
@hessjcg hessjcg reopened this Nov 30, 2022
@enocom enocom self-assigned this Nov 30, 2022
@enocom enocom mentioned this issue Nov 30, 2022
Merged
hessjcg pushed a commit that referenced this issue Dec 12, 2022
@enocom
feat: add user agent to proxy invocation (#122)
803446d 
Add the operator version to the proxy's user agent, so that we can track how many people
are using the operator.

Fixes #67.
Co-authored-by: Jonathan Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

@shubha-rajan shubha-rajan

Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v0.1 Private Preview
3 participants
@enocom @shubha-rajan @hessjcg