Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Private Service Connect configuration #389

Closed
hessjcg opened this issue Jul 18, 2023 · 0 comments · Fixed by #391 or #396
Closed

Support Private Service Connect configuration #389

hessjcg opened this issue Jul 18, 2023 · 0 comments · Fixed by #391 or #396
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hessjcg
Copy link
Collaborator

hessjcg commented Jul 18, 2023 •
edited
Loading

Add a flag for PSC similar to the PrivateIP flag (see internal/api/v1/authproxyworkload_types.go:323)

Depends on a release of the proxy with PSC support.
@hessjcg hessjcg added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 18, 2023
@hessjcg hessjcg mentioned this issue Jul 18, 2023
Merged
@enocom enocom removed their assignment Jul 18, 2023
hessjcg added a commit that referenced this issue Jul 20, 2023
@hessjcg
feat: Add support for Private Service Connect (#391)
116b776 
Adds support to configure private service connect through the operator. This will set the proxy's "psc=true" parameter
to the instance connection string passed to the proxy.

In accordance with the validation in the proxy, Users may not set both PrivateIP and PSC at the same time. See root.go:517

Fixes #389
@release-please release-please bot mentioned this issue Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@enocom @hessjcg