feat: add support for a lazy refresh #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a Dialer with the WithLazyRefresh option, the connection info and ephemeral certificate will be refreshed only when the cache certificate has expired. No background goroutines run with this option, making it ideal for use in Cloud Run and other serverless environments where the CPU may be throttled.
| @@ -42,6 +42,7 @@ type dialerConfig struct { | |||
| refreshTimeout time.Duration | |||
| useIAMAuthN bool | |||
| logger debug.Logger | |||
| lazyRefresh bool | |||
There was a problem hiding this comment.
do we want this as lazyRefresh or refreshType? do we see a future where we add another option for refreshes?
There was a problem hiding this comment.
As discussed elsewhere, we're keeping this field unexported so we can adapt it in the future if needed.
jackwotherspoon
approved these changes
Apr 15, 2024
This was referenced Apr 15, 2024
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
Apr 30, 2024
When creating a Dialer with the WithLazyRefresh option, the connection info and ephemeral certificate will be refreshed only when the cache certificate has expired. No background goroutines run with this option, making it ideal for use in Cloud Run and other serverless environments where the CPU may be throttled. This is a port of GoogleCloudPlatform/cloud-sql-go-connector#772 Fixes #549
enocom
added a commit
to GoogleCloudPlatform/alloydb-go-connector
that referenced
this pull request
May 1, 2024
When creating a Dialer with the WithLazyRefresh option, the connection info and ephemeral certificate will be refreshed only when the cache certificate has expired. No background goroutines run with this option, making it ideal for use in Cloud Run and other serverless environments where the CPU may be throttled. This is a port of GoogleCloudPlatform/cloud-sql-go-connector#772 Fixes #549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Dialer with the WithLazyRefresh option, the connection info and ephemeral certificate will be refreshed only when the cache certificate has expired. No background goroutines run with this option, making it ideal for use in Cloud Run and other serverless environments where the CPU may be throttled.
Fixes #770