Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CFT test lint subcommand, implement blueprint connection source version lint rule for POC #2631

Merged
merged 27 commits into from
Oct 21, 2024
Merged

feat: Add CFT test lint subcommand, implement blueprint connection source version lint rule for POC #2631

merged 27 commits into from
Oct 21, 2024

Conversation

qz267
Copy link
Contributor

@qz267 qz267 commented Sep 30, 2024 •
edited by q2w
Loading

This PR implemented go/blueprint-metadata-lint, implement a POC rule to verify the version value in ConnectionSource, valid version values including:

  • "=1.0.0"
  • ">=2.0.0"
  • ">=3.0.0 <5.0.0"
  • "~>4.0"

bharathkkb
bharathkkb reviewed Oct 3, 2024
View reviewed changes
cli/bptest/metadata_lint.go Outdated Show resolved Hide resolved
cli/bptest/metadata_lint.go Outdated Show resolved Hide resolved
cli/bptest/metadata_lint.go Outdated Show resolved Hide resolved
bharathkkb
bharathkkb reviewed Oct 3, 2024
View reviewed changes
cli/bptest/cmd.go Outdated Show resolved Hide resolved
@qz267 qz267 requested review from q2w and a team as code owners October 10, 2024 01:32
@qz267
Copy link
Contributor Author

qz267 commented Oct 10, 2024

a sample metadata lint output is:

-> % ~/src/cloud-foundation-toolkit/cli/bin/cft test lint
metadata, spec, or interfaces are nil
All lint checks passed!
zhengqin@yard [11:47:55 PM] [~/src/cloud-foundation-toolkit/cli/testdata/bpmetadata/content/examples/acm] [367401040-lint-ADC]
-> % ```

@qz267 qz267 changed the title [WIP] feat: Add CFT test lint subcommand feat: Add CFT test lint subcommand, implement blueprint connection source version lint rule for POC Oct 10, 2024
bharathkkb
bharathkkb reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @qz267

cli/bptest/metadata_lint_interface.go Outdated Show resolved Hide resolved
cli/bptest/metadata_lint.go Outdated Show resolved Hide resolved
cli/bptest/metadata_lint.go Outdated Show resolved Hide resolved
cli/bptest/metadata_lint.go Outdated Show resolved Hide resolved
cli/bptest/metadata_lint_interface.go Outdated Show resolved Hide resolved
cli/bptest/blueprint_version_rule.go Outdated Show resolved Hide resolved
cli/bptest/blueprint_version_rule_test.go Outdated Show resolved Hide resolved
cli/bptest/cmd.go Outdated Show resolved Hide resolved
cli/bptest/cmd.go Outdated Show resolved Hide resolved
bharathkkb
bharathkkb reviewed Oct 10, 2024
View reviewed changes
cli/bptest/cmd.go Outdated Show resolved Hide resolved
@qz267 qz267 requested a review from bharathkkb October 17, 2024 18:43
@qz267
Copy link
Contributor Author

qz267 commented Oct 17, 2024

@bharathkkb all comments addressed, will update design doc accordingly

bharathkkb
bharathkkb approved these changes Oct 18, 2024
View reviewed changes
cli/bptest/lint.go Outdated Show resolved Hide resolved
cli/bptest/cmd.go Outdated Show resolved Hide resolved
cli/bptest/blueprint_version_rule.go Outdated Show resolved Hide resolved
@qz267 qz267 requested review from bharathkkb and q2w October 18, 2024 14:28
@q2w q2w merged commit 2626d7a into GoogleCloudPlatform:master Oct 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik Awaiting requested review from g-awmalik

@apeabody apeabody Awaiting requested review from apeabody

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

@q2w q2w Awaiting requested review from q2w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qz267 @bharathkkb @q2w