feat: adding support for bq #1878
Conversation
bradmiro
requested review from
bharathkkb,
g-awmalik and
apeabody
as code owners
infra/blueprint-test/pkg/bq/bq.go
Outdated
| } | ||
|
|
||
| // ActivateCredsAndEnvVars activates credentials and exports auth related envvars. | ||
| func ActivateCredsAndEnvVars(t testing.TB, creds string) { |
There was a problem hiding this comment.
This does not seem BQ specific and might be a better fit in utils?
There was a problem hiding this comment.
I copied this directly from gcloud.go since auth is the same - I can move it from here (and there) to utils if that makes sense. Or I can leave it as-is in gcloud.go
There was a problem hiding this comment.
Good point, since the logic is the same is there any advantage to mirroring this in bq package? Maybe we can just leave it in gcloud for now.
infra/blueprint-test/pkg/bq/bq.go
Outdated
| } | ||
|
|
||
| // stringFromTextAndArgs convert msg and args to formatted text | ||
| func stringFromTextAndArgs(msgAndArgs ...interface{}) string { |
There was a problem hiding this comment.
Since we are starting to use this for both gcloud and bq, I think centralizing this in utils might be good.
There was a problem hiding this comment.
I can move this out of both files but that might result in a breaking change if the function in gcloud.go was referenced in any downstream projects - wdyt? (I'm less familiar with Golang best practices so apologies if there's an easy fix here I'm unaware of)
There was a problem hiding this comment.
Since it was unexported from gcloud package it is okay to move
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
infra/blueprint-test/pkg/bq/bq.go
Outdated
| } | ||
|
|
||
| // ActivateCredsAndEnvVars activates credentials and exports auth related envvars. | ||
| func ActivateCredsAndEnvVars(t testing.TB, creds string) { |
There was a problem hiding this comment.
Good point, since the logic is the same is there any advantage to mirroring this in bq package? Maybe we can just leave it in gcloud for now.
bharathkkb
merged commit d4b0385
into
GoogleCloudPlatform:master
Adding support for
bqcommand line tool.