Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push container images to GitHub instead of Google Container Registry #995

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

kunzese
Copy link
Collaborator

@kunzese kunzese commented Nov 21, 2022

This PR adds workflows that push the Squid, strongSwan and Toolbox container images to GitHub. This solution consists of a generic Build & Push reusable workflow which is triggered by a separate workflow for each image. In my opinion this is the best, GitHub-nativ approach which does not depend on some git diff/bash magic - but other opinions are highly welcomed.

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm ignorant so I'll ask: do we need to update container image links in the examples using these?

@kunzese kunzese enabled auto-merge (squash) November 21, 2022 14:47
@kunzese kunzese merged commit b6249bc into master Nov 21, 2022
@kunzese kunzese deleted the kunzese/move-images-from-gcp-to-github branch November 21, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants