Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemas to Pubsub topic module. #994

Merged
merged 6 commits into from
Nov 20, 2022

Conversation

iht
Copy link
Member

@iht iht commented Nov 20, 2022

Pubsub topics can now have schemas (https://cloud.google.com/pubsub/docs/admin#schemas).

This PR adds an option to set the schema settings and create a new optional resource of type google_pubsub_schema attached to the google_pubsub_topic.

Pubsub topics can now have
schemas (https://cloud.google.com/pubsub/docs/admin#schemas). This PR adds an
option to set the schema settings and create a new optional resource of type
`google_pubsub_schema` attached to the `google_pubsub_topic`.
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome @iht :)

modules/pubsub/outputs.tf Outdated Show resolved Hide resolved
modules/pubsub/main.tf Outdated Show resolved Hide resolved
modules/pubsub/variables.tf Outdated Show resolved Hide resolved
modules/pubsub/main.tf Outdated Show resolved Hide resolved
@ludoo
Copy link
Collaborator

ludoo commented Nov 20, 2022

nice commit message :)
image

Israel, I'm adding you to the repo users, you should be able to merge yourself after you accept the invite (I don't think we added you before)

@iht iht merged commit f26e864 into GoogleCloudPlatform:master Nov 20, 2022
@iht iht deleted the add_pubsub_schema branch November 21, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants