Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Secondary IP Utilization calculation #982

Merged
merged 8 commits into from
Dec 7, 2022
Merged

Adding Secondary IP Utilization calculation #982

merged 8 commits into from
Dec 7, 2022

Conversation

brianhmj
Copy link
Collaborator

Added a secondarys.py that looks at all secondary IP addresses used by GKE for different secondary ranges.

Next Steps:
Add alias IP used by VMs (GCE)

aurelienlegrand
aurelienlegrand reviewed Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution Brian! Adding a few comments, could you please have a look?

blueprints/cloud-operations/network-dashboard/cloud-function/metrics/secondarys.py Show resolved Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/secondarys.py Show resolved Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/secondarys.py Show resolved Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/secondarys.py Outdated Show resolved Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/secondarys.py Outdated Show resolved Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/secondarys.py Outdated Show resolved Hide resolved
blueprints/cloud-operations/network-dashboard/cloud-function/metrics/subnets.py Show resolved Hide resolved
@aurelienlegrand
Copy link
Collaborator

Also, could you please add a dashboard to display the utilization of the secondary ranges?
For this, I would recommend to:

  • Go to the dashboard page
  • Modify the dashboard using the GUI tool
  • Export the updated dashboard with gcloud monitoring dashboards describe $DASHBOARD_ID --format=json
  • Copy the changes to the dashboards/quota-utilization.json file

aurelienlegrand
aurelienlegrand approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for your contribution Brian!

@aurelienlegrand aurelienlegrand merged commit 5b71f2f into GoogleCloudPlatform:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurelienlegrand aurelienlegrand aurelienlegrand approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianhmj @aurelienlegrand @brianhmjung