-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have Squid log to /dev/stdout to stream logs to Cloud Logging #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost calls for docker compose :)
Good idea - i will adjust this PR. |
you probably need to download docker-compose, which will then fail if there's no public access. :) interested in what you come up with, but this PR is totally fine as is if you want to merge! |
i have a strange feeling about starting container with USER=${squid_user} and then using Also I generally not sure why root permissions are necessary at all, because /dev/std* (link to /proc/self/fd/1) should be writable by the userID which runs the process. Have you checked that it does not work without sudo? |
LGTM :) |
This PR uses dark Docker voodoo to make the Squid container able to log to /dev/stdout, which then get streamed to Cloud Logging via the COS logging agent.
FYI: @gaspar-chilingarov