Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add network tags support to the organization module #979

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Add network tags support to the organization module #979

merged 6 commits into from
Nov 18, 2022

Conversation

LucaPrete
Copy link
Member

No description provided.

@LucaPrete LucaPrete requested a review from ludoo November 15, 2022 13:23
@juliocc
Copy link
Collaborator

juliocc commented Nov 15, 2022

networks_tags, pretty please? network_tags might cause confusion, but tags_network is worse IMO.

And now that we're on it, the existing tags could be renamed to resource_tags?

@LucaPrete
Copy link
Member Author

Don't have an opinion on it @juliocc. I've just used tags_network to keep them closed in alphabetical order, but I'm fine either way.
Let me rename tags_network to network_tags in this patch, and then create another one to rename resource_tags, so we keep the scope of the PR small.

@LucaPrete LucaPrete force-pushed the add-net-tags-support branch 2 times, most recently from b4ea730 to a839e05 Compare November 17, 2022 13:29
@LucaPrete LucaPrete marked this pull request as ready for review November 17, 2022 18:34
@ludoo ludoo changed the title Add netwok tags support to the organization module Add network tags support to the organization module Nov 18, 2022
ludoo
ludoo approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luca, can you just make sure variables and outputs are in alphabetical order?

@LucaPrete LucaPrete force-pushed the add-net-tags-support branch from adbb6bf to a64fd03 Compare November 18, 2022 14:42
@LucaPrete LucaPrete force-pushed the add-net-tags-support branch from a64fd03 to beb8e93 Compare November 18, 2022 14:42
@LucaPrete
Copy link
Member Author

Done.

@LucaPrete LucaPrete merged commit 4124ef4 into master Nov 18, 2022
@LucaPrete LucaPrete deleted the add-net-tags-support branch November 18, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucaPrete @juliocc @ludoo