Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: fixes to GitHub workflow and 02/net outputs #976

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Nov 15, 2022

This fixes a few things in the GitHub workflow

  • include plan stderr in PR comment
  • remove the code to post to the action status page, as that too has a message length limit
  • additional step to error workflow if plan or apply fails, needed since the plan and apply steps have continue-on-error: true to allow the PR comment step to always run
  • set continue-on-error: true on the step that posts the PR comment, and add a second step that posts a shorter comment which omits plan standard output in case of failure due to comment length

It also fixes file outputs for the networking stages, which raise an error if the outputs_location variable is not set.

@ludoo ludoo added the on:FAST label Nov 15, 2022
@ludoo ludoo requested review from juliocc and amgoogle November 15, 2022 00:20
@ludoo ludoo changed the title FAST: fixes to GitHub workflow FAST: fixes to GitHub workflow and 02/net outputs Nov 15, 2022
@ludoo ludoo enabled auto-merge (squash) November 15, 2022 07:29
@ludoo ludoo merged commit ad483e3 into master Nov 15, 2022
@ludoo ludoo deleted the ludo/fast/gh-worflow-fix branch November 15, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants