-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix variable consistency across modules #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also a few cases inside the blueprints folder. What do we want to do with those?
I'll try to see how long it might take me to go through the blueprints=) Being a perfectionist, I would ideally fix everywhere%) The other question is, should we add the same in fast/ (adding to existing validation and things)? Example: 00-bootstrap. No default null, can be an empty string though. Right? Wouldn't that break some things? Or am I misreading it? |
FAST does its own thing with prefixes. I'd focus only on blueprints for now. |
So, the modules/ folder is ready, and I would suggest to merge this and leave blueprints/ for later for a separate issue/pull request, because the changes there would be bigger (there's quite a lot to change) - and they're just blueprints, conceptually it's more of a "perfectionism" to change them, I believe. Although I will see if I can work on that later too, of course. |
Thanks :) |
Modules/ folder ready - consistent usage of the "prefix" variable
Fixes #954