Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use display_name instead of description for FAST service accounts #948

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Use display_name instead of description for FAST service accounts #948

merged 1 commit into from
Nov 3, 2022

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Nov 3, 2022

Fixes #944

@juliocc juliocc requested review from ludoo and maunope November 3, 2022 15:25
@juliocc juliocc added the on:FAST label Nov 3, 2022
ludoo
ludoo approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a breaking change? we should mark it as such in case

@juliocc
Copy link
Collaborator Author

juliocc commented Nov 3, 2022

is this a breaking change? we should mark it as such in case

Nothing breaks. It just updates the SAs in place.

@juliocc juliocc merged commit 3160d61 into master Nov 3, 2022
@juliocc juliocc deleted the jccb/fix-944 branch November 3, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@maunope maunope Awaiting requested review from maunope

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service accounts have all the same name, Asset Inventory search results hard to read
2 participants
@juliocc @ludoo