Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve net dashboard variables #900

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Improve net dashboard variables #900

merged 4 commits into from
Oct 20, 2022

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Oct 20, 2022

  • add variable documentation to the readme
  • sort variables alphabetically
  • validate values for cf_version

aurelienlegrand
aurelienlegrand approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Julio for making this more "production ready" with better documentation :)

@juliocc juliocc force-pushed the jccb/dashboard-vars branch from cbfcd32 to ea9227d Compare October 20, 2022 17:10
@juliocc juliocc merged commit ececb82 into master Oct 20, 2022
@juliocc juliocc deleted the jccb/dashboard-vars branch October 20, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurelienlegrand aurelienlegrand aurelienlegrand approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @aurelienlegrand