Add network NVA NCC stage

[LucaPrete]

No description provided.

[sruffilli]

Would it be possible to submit this -at least for review- as an evolution of 02-networking-nva?
This would reduce the review complexity by a lot.

[LucaPrete]

I'd rather refrain/wait to do this for two reasons:

1. I'd prefer to complete this first (writing provider + config for NVAs) to see the real delta
2. I think there's still lots of value in the NVA module with static routes. As such, the only other option to keep both would be adding a conditional that would trigger the dynamic routing installation vs static....which seems exactly the kind of magic we want to avoid in FAST

Not saying we won't do it, but I'd least wait to see how this evolves first.

[sruffilli]

I don't disagree Luca - and I would probably have the two stages co-exist, at least for a while.
But I'd prefer to review this PR as a delta of the NVA stage, rather than have to re-process and re-read the whole stage.
This shouldn't happen right now, but only once the PR will be ready for review.

Once reviewed I'd restore the original NVA stage to have both available.

[LucaPrete]

Ah gotcha. Makes sense. I’ll do that. Il giorno mer 19 ott 2022 alle 19:15 Simone Ruffilli < ***@***.***> ha scritto:

…

I don't disagree Luca - and I would probably have the two stages co-exist, at least for a while. But I'd prefer to review this PR as a delta of the NVA stage, rather than have to re-process and re-read the whole stage. This shouldn't happen right now, but only once the PR will be ready for review. Once reviewed I'd restore the original NVA stage to have both available. — Reply to this email directly, view it on GitHub <#892 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARY7UB53Q6RVXN2VD3BFZDWEAUDHANCNFSM6AAAAAARHJOP5U> . You are receiving this because you were assigned.Message ID: ***@***.*** com>

[ludoo]

@LucaPrete can we close this?

[LucaPrete]

I would not. I'm still missing the latest terraform provider PR to be in, so I can finish to implement this here. It should be merged hopefully soon.

FYI ref: GoogleCloudPlatform/magic-modules#6874

[juliocc]

Is this ready to be merged @LucaPrete?

[LucaPrete]

@sruffilli @simonebruzzechesse @ludoo please review this but wait to merge it, as we will copy this to a new networking stage once you approve.

[ludoo]

You will be the one merging it once approved, we usually don't :)

…

On Tue, Mar 21, 2023 at 10:36 AM Luca Prete ***@***.***> wrote: @sruffilli <https://github.com/sruffilli> @simonebruzzechesse <https://github.com/simonebruzzechesse> @ludoo <https://github.com/ludoo> please review this but wait to merge it, as we will copy this to a new networking stage once you approve. — Reply to this email directly, view it on GitHub <#892 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQDV5ALN7HB72TWVAUK4LW5FZAJANCNFSM6AAAAAARHJOP5U> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

-- * • **Ludovico Magnocavallo* * • *Strategic Cloud Engineer * • *Google Italy * • ***@***.*** • +39 335 691 2196 This email may be confidential and privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.

[LucaPrete]

Is this ready to be merged @LucaPrete?

yes @juliocc (imho) :)

[sruffilli]

Some minor comment.

[juliocc]

Is this ready to be merged @LucaPrete?

yes @juliocc (imho) :)

that's what I call a quick turnaround

[LucaPrete]

🤣 Il giorno mar 21 mar 2023 alle 16:31 Julio Castillo < ***@***.***> ha scritto:

…

Is this ready to be merged @LucaPrete <https://github.com/LucaPrete>? yes @juliocc <https://github.com/juliocc> (imho) :) that's what I call a quick turnaround — Reply to this email directly, view it on GitHub <#892 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARY7UDBKLUB4WGZHM6BJ7DW5HCTNANCNFSM6AAAAAARHJOP5U> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[LucaPrete]

@simonebruzzechesse @sruffilli this for me is now final and ready to be reviewed.
Please check again, before I create the new net stage and merge. Thank you!

[ludoo]

@LucaPrete should this be a diff against the current NVA stage, or a completely new stage? If the first, are we sure all customers are ok using NCC?

[LucaPrete]

The plan is to review it first as a diff. Once it’s ready we should create a separate net nva stage and leave the current simple nva as is. Il giorno lun 3 apr 2023 alle 20:07 Ludovico Magnocavallo < ***@***.***> ha scritto:

…

@LucaPrete <https://github.com/LucaPrete> should this be a diff against the current NVA stage, or a completely new stage? If the first, are we sure all customers are ok using NCC? — Reply to this email directly, view it on GitHub <#892 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARY7UBU3NEV5ADPGWROJHDW7MGX7ANCNFSM6AAAAAARHJOP5U> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[ludoo]

Perfect! Thanks for confirming.

…

On Mon, Apr 3, 2023 at 8:15 PM Luca Prete ***@***.***> wrote: The plan is to review it first as a diff. Once it’s ready we should create a separate net nva stage and leave the current simple nva as is. Il giorno lun 3 apr 2023 alle 20:07 Ludovico Magnocavallo < ***@***.***> ha scritto: > @LucaPrete <https://github.com/LucaPrete> should this be a diff against > the current NVA stage, or a completely new stage? If the first, are we sure > all customers are ok using NCC? > > — > Reply to this email directly, view it on GitHub > < #892 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AARY7UBU3NEV5ADPGWROJHDW7MGX7ANCNFSM6AAAAAARHJOP5U > > . > You are receiving this because you were mentioned.Message ID: > ***@***.*** > com> > — Reply to this email directly, view it on GitHub <#892 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQDV6CE4UBEBFC7CE2RFTW7MHVJANCNFSM6AAAAAARHJOP5U> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

-- * • **Ludovico Magnocavallo* * • *Strategic Cloud Engineer * • *Google Italy * • ***@***.*** • +39 335 691 2196 This email may be confidential and privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.