Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firewall Policy Metrics, parallel writes, aligned timestamps #871

Merged
merged 25 commits into from
Oct 19, 2022
Merged

Firewall Policy Metrics, parallel writes, aligned timestamps #871

merged 25 commits into from
Oct 19, 2022

Conversation

maunope
Copy link
Collaborator

@maunope maunope commented Oct 10, 2022

Firewall Policy Metrics, parallel writes, aligned timestamps

maunope and others added 17 commits October 3, 2022 15:48
@maunope
support for project level VPC firewall metrics
cdf5355
@maunope
Added charts to dashboard, fixed a merge glitch, updated readme, remo…
7f2399b 
…ved hardcoded parameters
@maunope
Merge branch 'GoogleCloudPlatform:master' into maunope/network-dashbo…
338ffe4 
…ards-updates
@maunope
removed hardcoded debug value
bebe9ed
@maunope
removed obsolete code - compute api firewalls list
14da0ee
@maunope
Merge branch 'master' into maunope/network-dashboards-updates
8d39ded
@maunope
fixed PR GoogleCloudPlatform#856 comments
c0573ce
@maunope
Merge branch 'maunope/network-dashboards-updates' of https://github.c…
2df2bbd 
…om/maunope/cloud-foundation-fabric into maunope/network-dashboards-updates
@maunope
Merge branch 'master' into maunope/network-dashboards-updates
6e128ee
@maunope
fixed dashboard comments
1f3cfe8
@maunope
solved pul comments and fixed grouping on firewalls utilization chart
ac82a8c
@maunope
Merge branch 'master' into maunope/network-dashboards-updates
dffd5b4
@aurelienlegrand
Merge branch 'master' into maunope/network-dashboards-updates
17ee413
@maunope
Added Firewall Policies Monitoring, added buffered metric writes (CF …
82f3daf 
…now 4x faster on my laptop), switched to aligned timestamps (should avoid "sawtoothing")
@maunope
Added Firewall Policies Monitoring
c52b623 
Added buffering for writes (execution now 4x faster on my laptop)
Added aligned timestamps per monitored resource type
@maunope
Merge branch 'maunope/network-dashboards-updates' of https://github.c…
3b259a9 
…om/maunope/cloud-foundation-fabric into maunope/network-dashboards-updates
@maunope
updated dashbaord and readme
3608b57
@aurelienlegrand
Copy link
Collaborator

Hi Maurizio, thanks for the PR!
A few comments:

  1. Can you update your PR with the latest changes from master? There are a lot of conflicts.
  2. I have some doubts too regarding the dashboard, can you try exporting it again?
  3. you removed the "write_data_to_metric" function in metrics.py to replace it with a "better append_data_to_series_buffer" which is a good idea... But lots of parts of the code are still using the write_data_to_metric function and will break so we need to replace these calls with the new function too.

aurelienlegrand
aurelienlegrand approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@aurelienlegrand aurelienlegrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes, adding a new metric (Firewall Policies) and greatly improving the performance of this solution!

@maunope maunope merged commit 61dd7f0 into GoogleCloudPlatform:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurelienlegrand aurelienlegrand aurelienlegrand approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maunope @aurelienlegrand @juliocc