Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GKE module for Terraform 1.3 #868

Merged
merged 10 commits into from
Oct 10, 2022
Merged

Refactor GKE module for Terraform 1.3 #868

merged 10 commits into from
Oct 10, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Oct 9, 2022

This refactors streamlines the GKE module variables. A followup PR will refactor the multitenant blueprint and FAST stage to expose all cluster configurations via optional attributes, leveraging the new interface.

@ludoo ludoo requested review from juliocc and danielmarzini October 9, 2022 17:57
@ludoo ludoo added on:FAST on:modules on:blueprints incompatible change Pull request that breaks compatibility with previous version labels Oct 9, 2022
@ludoo ludoo marked this pull request as ready for review October 9, 2022 21:12
modules/gke-cluster/variables.tf Show resolved Hide resolved
modules/gke-cluster/variables.tf Outdated Show resolved Hide resolved
@ludoo ludoo merged commit 16822e9 into master Oct 10, 2022
@ludoo ludoo deleted the ludo/gke-tf1.3 branch October 10, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:blueprints on:FAST on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants