Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compute-vm for Terraform 1.3 #860

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Oct 6, 2022

This PR takes a minimal approach, so as to preserve the original interface as much as possible while still allowing to omit most non-required attributes. Tests pass, some additional tests might be needed if we want to have full coverage of the interface.

@ludoo ludoo requested a review from juliocc October 6, 2022 18:21
@ludoo ludoo added incompatible change Pull request that breaks compatibility with previous version on:modules labels Oct 6, 2022
.github/workflows/tests.yml Show resolved Hide resolved
@ludoo ludoo merged commit e66340c into master Oct 7, 2022
@ludoo ludoo deleted the ludo/compute-vm-tf1.3 branch October 7, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants