Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COS based simple networking appliance #846

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Conversation

sruffilli
Copy link
Collaborator

Pending tests and README

@juliocc
Copy link
Collaborator

juliocc commented Sep 29, 2022

Woult it make sense to build this on top of the cloud-config-container module?

@ludoo
Copy link
Collaborator

ludoo commented Sep 29, 2022

Woult it make sense to build this on top of the cloud-config-container module?

👍 cloud config containers already have provisions for a VM, and that suite of modules only spit out a cloud config, so users can easily adapt them to different usecases, for example by plugging them into instance templates, etc.

@sruffilli
Copy link
Collaborator Author

Still missing tests but otherwise ready to merge. PTAL.

@sruffilli sruffilli requested review from juliocc and ludoo September 30, 2022 16:13
@sruffilli sruffilli marked this pull request as ready for review September 30, 2022 16:17
@sruffilli sruffilli merged commit 5950797 into master Sep 30, 2022
@sruffilli sruffilli deleted the sruffilli/simple-nva branch September 30, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants