-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example wordpress #818
Example wordpress #818
Conversation
This is great, let us know once it's ready for review! |
Thank you!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to put this blueprint in blueprints/third-party-solutions/wordpress/cloudrun
instead of blueprints/third-party/wordpress
directly?
Yes, the original idea was to have another example on VMs. This was discussed with Ludovico. We can move one folder up for now, of course, and change later, once the other example is there. Let us know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple more comments :)
As discussed, the reasoning is valid, so leaving as is for now.
I just found a bug, not sure it's related to Terraform, but please don't merge just yet. But otherwise my new changes can be reviewed. |
Bug not a real bug, added a README point=) Ready to be merged from my side=) |
awesome, and thanks for all the hard work! let us give it a last glance and this can then be merged today! |
This is still work in progress, but almost finished, so the directory structure and logic can be reviewed.
Fixes #781