Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change modules/project service_config default #805

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Change modules/project service_config default #805

merged 2 commits into from
Sep 9, 2022

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Sep 9, 2022

this commit:

  • Disables API deactivation by default on project destruction
  • Adds "jit" service accounts as explicit dependency to the project_id output
  • Makes project_id and number outputs depend_on the same resources

@juliocc juliocc requested review from ludoo and sruffilli September 9, 2022 07:10
ludoo
ludoo approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh God, yes!

@juliocc juliocc merged commit c5216c7 into master Sep 9, 2022
@juliocc juliocc deleted the jccb/project-apis branch September 9, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@sruffilli sruffilli Awaiting requested review from sruffilli

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @ludoo