Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloud SQL example #801

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Update Cloud SQL example #801

merged 5 commits into from
Sep 9, 2022

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Sep 8, 2022

Update Cloud SQL example:

  • Support externally configured Shared VPC
  • Support externally configured KMS keys
  • Fix diagram and diagram link

@lcaggio lcaggio marked this pull request as ready for review September 8, 2022 16:00
examples/data-solutions/cloudsql-multiregion/README.md Outdated Show resolved Hide resolved
examples/data-solutions/cloudsql-multiregion/README.md Outdated Show resolved Hide resolved
examples/data-solutions/cloudsql-multiregion/README.md Outdated Show resolved Hide resolved
examples/data-solutions/cloudsql-multiregion/README.md Outdated Show resolved Hide resolved
examples/data-solutions/cloudsql-multiregion/README.md Outdated Show resolved Hide resolved
examples/data-solutions/cloudsql-multiregion/cloudsql.tf Outdated Show resolved Hide resolved
examples/data-solutions/cloudsql-multiregion/cloudsql.tf Outdated Show resolved Hide resolved
@lcaggio lcaggio requested a review from ludoo September 9, 2022 09:37
@lcaggio lcaggio merged commit 33d05ae into master Sep 9, 2022
@lcaggio lcaggio deleted the lcaggio/cloudsql-shared branch September 9, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants