Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: fix data-platform-dev folder in stage 03-data-platform #774

Merged

Conversation

sttomm
Copy link
Contributor

@sttomm sttomm commented Aug 15, 2022

I did run all Fabric Fast steps and noticed an issue when applying the 03-data-platform stage. It references to a non-existing folder. The 01-resman stage creates specific data-platform-dev and data-platform-prod folders and writes them to the resulting tfvars file. As this file is used as input to stage 03-data-platform, the specific data-platform-dev folder must be referenced, but actually only a generic data-platform folder, which does not exist, was referenced.

With this PR i fixed it to use the existing data-platform-dev folder.

@google-cla
Copy link

google-cla bot commented Aug 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sttomm sttomm changed the title fix data-platform-dev folder in stage 03-data-platform FAST: fix data-platform-dev folder in stage 03-data-platform Aug 15, 2022
@ludoo
Copy link
Collaborator

ludoo commented Aug 15, 2022

Hey Stefan, thanks for this! Could you merge master in, or give us permissions to do so? Linting and tests also need attention, you can check our contributing guide, or we can do it once we can push to your fork.

@sttomm sttomm force-pushed the fix-dataplatform-dev-folder branch from efeeab3 to 17aebe8 Compare August 16, 2022 05:52
@sttomm
Copy link
Contributor Author

sttomm commented Aug 16, 2022

Hi Ludovico, thanks for the quick review! I think i fixed the linting and the tests. I also rebased to master. Just wasn't able to execute pytest locally due to some errors.

You also have access to our repo now and could also apply changes if needed.

@ludoo ludoo merged commit 5b7f6ab into GoogleCloudPlatform:master Aug 16, 2022
@ludoo
Copy link
Collaborator

ludoo commented Aug 16, 2022

Thanks Stefan, all good! I think you can mark forks as accessible from the forked repo admins when you create the fork, no need to share individually next time. :)

@ludoo ludoo added the on:FAST label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants