Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Data Playground example #738

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Improve Data Playground example #738

merged 7 commits into from
Aug 9, 2022

Conversation

lcaggio
Copy link
Collaborator

@lcaggio lcaggio commented Jul 14, 2022

  • Add support to KMS
  • Add dedicated SA
  • Add firewall rule to SSH to the VM
  • Add BQ
  • Update diagram

@lcaggio lcaggio requested review from aymanfarhat and ludoo July 14, 2022 16:12
@lcaggio lcaggio marked this pull request as ready for review July 14, 2022 16:12
aymanfarhat
aymanfarhat suggested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@aymanfarhat aymanfarhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition, thank you @lcaggio it's now a much more useful example. I added a couple of comments and small requests but overall LGTM.

examples/data-solutions/data-playground/README.md Outdated Show resolved Hide resolved
examples/data-solutions/data-playground/outputs.tf Show resolved Hide resolved
examples/data-solutions/data-playground/main.tf Outdated Show resolved Hide resolved
examples/data-solutions/data-playground/README.md Show resolved Hide resolved
examples/data-solutions/data-playground/main.tf Outdated Show resolved Hide resolved
examples/data-solutions/data-playground/main.tf Show resolved Hide resolved
@lcaggio lcaggio requested review from sruffilli and juliocc July 19, 2022 08:17
@ludoo ludoo merged commit c0e17f4 into master Aug 9, 2022
@ludoo ludoo deleted the lcaggio/improve-data-playground branch August 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanfarhat aymanfarhat aymanfarhat approved these changes

@ludoo ludoo ludoo approved these changes

@sruffilli sruffilli Awaiting requested review from sruffilli

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcaggio @ludoo @aymanfarhat