Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ip_range variable description in apigee-x-instance module #727

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

alexlo03
Copy link
Contributor

@alexlo03 alexlo03 commented Jul 8, 2022

Current docs are incorrect. It is not possible to specify the Support CIDR on instance create.

See https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.instances#Instance

ipRange
string
Optional. IP range represents the customer-provided CIDR block of length 22 that will be used for the Apigee instance creation. This optional range, if provided, should be freely available as part of larger named range the customer has allocated to the Service Networking peering. If this is not provided, Apigee will automatically request for any available /22 CIDR block from Service Networking. The customer should use this CIDR block for configuring their firewall needs to allow traffic from Apigee. Input format: "a.b.c.d/22", Output format: a.b.c.d/22, e.f.g.h/28"

Current docs are incorrect. It is not possible to specify the Support range.

See https://cloud.google.com/apigee/docs/reference/apis/apigee/rest/v1/organizations.instances#Instance

> ipRange	
> string
> Optional. IP range represents the customer-provided CIDR block of length 22 that will be used for the Apigee instance creation. This optional range, if provided, should be freely available as part of larger named range the customer has allocated to the Service Networking peering. If this is not provided, Apigee will automatically request for any available /22 CIDR block from Service Networking. The customer should use this CIDR block for configuring their firewall needs to allow traffic from Apigee. Input format: "a.b.c.d/22", Output format: a.b.c.d/22, e.f.g.h/28"
@google-cla
Copy link

google-cla bot commented Jul 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo
Copy link
Collaborator

ludoo commented Jul 10, 2022

Thanks for the PR! Could you run tools/tfdoc on the module folder to regenerate the variables table, as explained in our contributing guide?

@ludoo ludoo merged commit 307bda4 into GoogleCloudPlatform:master Aug 11, 2022
@ludoo ludoo changed the title apigee-x-instance.ip_range cannot take Support CIDR Fix ip_range variable description in apigee-x-instance module Aug 11, 2022
@alexlo03 alexlo03 deleted the patch-1 branch January 22, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants