Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New AD FS example #712

Merged
merged 1 commit into from
Jul 11, 2022
Merged

New AD FS example #712

merged 1 commit into from
Jul 11, 2022

Conversation

apichick
Copy link
Collaborator

@apichick apichick commented Jul 4, 2022

No description provided.

@ludoo ludoo requested a review from drebes July 4, 2022 12:35
@ludoo
Copy link
Collaborator

ludoo commented Jul 4, 2022

@drebes would you ind reviewing this?

ludoo
ludoo approved these changes Jul 10, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice example, thanks a lot for this! Dropped a few cosmetic comments, feel free to merge once you have resolved them.

examples/cloud-operations/adfs/README.md Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/README.md Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/README.md Show resolved Hide resolved
examples/cloud-operations/adfs/main.tf Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/main.tf Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/main.tf Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/main.tf Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/scripts/ad-provisioning/main.py Outdated Show resolved Hide resolved
examples/cloud-operations/adfs/scripts/ad-provisioning/main.py Outdated Show resolved Hide resolved
@ludoo ludoo removed the request for review from drebes July 10, 2022 07:27
@apichick apichick merged commit fc6265b into GoogleCloudPlatform:master Jul 11, 2022
@ludoo ludoo changed the title AD FS example New AD FS example Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apichick @ludoo